Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()

From: Simon Horman
Date: Thu Jun 15 2023 - 10:40:39 EST


On Thu, Jun 15, 2023 at 03:51:49PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> > On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > > left behind this, remove it.
> > >
> > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> >
> > Yeah this is a stub for !CONFIG_XDP_SOCKETS...
>
> Wait, I am not sure if this should go to bpf tree and have fixes tag
> pointing to the cited commit?
>
> Functionally this commit does not fix anything but it feels that
> f2f167583601 was incomplete.

FWIIW, I think that bpf-next is appropriate for this patch
as it doesn't address a bug.