Re: [PATCH] kbuild: revive "Entering directory" for Make >= 4.4.1

[Masahiro Yamada]

On Thu, Jun 15, 2023 at 5:34 AM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> On Sun 11 Jun 2023 01:17:11 +0900, Masahiro Yamada wrote:
> > With commit 9da0763bdd82 ("kbuild: Use relative path when building in
> > a subdir of the source tree"), compiler messages in out-of-tree builds
> > include relative paths, which are relative to the build directory, not
> > the directory where make was started.
> >
> > To help IDEs/editors find the source files, Kbuild lets GNU Make print
> > "Entering directory ..." when it changes the working directory. It has
> > been working fine for a long time, but David reported it is broken with
> > GNU Make 4.4.1.
> >
> > The behavior was changed by GNU Make commit 8f9e7722ff0f ("[SV 63537]
> > Fix setting -w in makefiles"). Previously, setting --no-print-directory
> > to MAKEFLAGS only affected child makes, but it is now interpreted in
> > the current make as soon as it is set.
> >
> > [test code]
> >
> >   $ cat /tmp/Makefile
> >   MAKEFLAGS += --no-print-directory
> >   all: ; :
> >
> > [before 8f9e7722ff0f]
> >
> >   $ make -C /tmp
> >   make: Entering directory '/tmp'
> >   :
> >   make: Leaving directory '/tmp'
> >
> > [after 8f9e7722ff0f]
> >
> >   $ make -C /tmp
> >   :
> >
> > This commit restores the previous behavior for GNU Make >= 4.4.1.
> >
> > Reported-by: David Howells <dhowells@xxxxxxxxxx>
> > Closes: https://lore.kernel.org/all/2427604.1686237298@xxxxxxxxxxxxxxxxxxxxxx/
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---


Sorry, I retract this patch.
It does not work.

-- 
Best Regards
Masahiro Yamada