Re: [PATCH] of: unittest: drop assertions for GPIO hog messages

From: Rob Herring
Date: Thu Jun 15 2023 - 10:10:47 EST


On Fri, Jun 9, 2023 at 2:15 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Fri, Jun 9, 2023 at 7:01 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> >
> > On Fri, Jun 9, 2023 at 8:36 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > >
> > > These have now been demoted to debug and are normally hidden. Drop the
> > > assertions entirely.
> > >
> > > Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > > ---
> > > drivers/of/unittest.c | 28 ----------------------------
> > > 1 file changed, 28 deletions(-)
> >
> > Why is this a separate patch? Don't I get at least 5 days to
> > review/ack changes in drivers/of/?
> >
>
> Sorry, my bad, I queued the previous one through the GPIO tree after
> it was reviewed here thinking the unittests bits are trivial. I can
> back it out if you insist or you can ack this one and the end effect
> is the same? I will pay attention in the future.

I'd prefer it to be squashed, but either way:

Acked-by: Rob Herring <robh@xxxxxxxxxx>