Re: [PATCH 1/6] rust: init: make doctests compilable/testable

From: Martin Rodriguez Reboredo
Date: Thu Jun 15 2023 - 09:34:24 EST


On 6/15/23 06:31, Miguel Ojeda wrote:
On Thu, Jun 15, 2023 at 5:52 AM Martin Rodriguez Reboredo
<yakoyoku@xxxxxxxxx> wrote:

Little question, what's the purpose of `FromErrno` here?

It was because `Error::from_errno` is `pub(crate)` in the `kernel`
crate. I should have added a comment -- my bad! :)

If we decided to make it `pub` eventually, then this `FromErrno` hack
can be removed.

Cheers,
Miguel

I think that `FromErrno` should be made public the moment when more
doctests rely upon it, until then.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>