Re: [PATCH v3 1/3] ASoC: Add support for Loongson I2S controller

[Yingkun Meng]

On 2023/6/15 19:30, Mark Brown wrote:
> On Wed, Jun 14, 2023 at 08:21:40PM +0800, YingKun Meng wrote:
> > From: Yingkun Meng <mengyingkun@xxxxxxxxxxx>
> >
> > Loongson I2S controller is found on 7axxx/2kxxx chips from loongson,
> > it is a PCI device with two private DMA controllers, one for playback,
> > the other for capture.
> >
> > The driver supports the use of DTS or ACPI to describe device resources.
> One minor thing which can be done as an incremental patch:
>
> > +/*
> > + * DMA registers descriptor.
> > + */
> > +struct loongson_dma_desc {
> > +	u32 order;		/* Next descriptor address register */
> This probably needs a __packed to ensure the layout doesn't get changed
> by the compiler (eg, with struct randomisation options).

OK, got it.

Thanks,

Yingkun