RE: [PATCH] crypto: caam - adjust RNG timing to support more devices

From: Gaurav Jain
Date: Thu Jun 15 2023 - 07:51:24 EST


Reviewed-by: Gaurav Jain <gaurav.jain@xxxxxxx>

> -----Original Message-----
> From: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> Sent: Monday, June 12, 2023 1:56 PM
> To: Horia Geanta <horia.geanta@xxxxxxx>; Varun Sethi <V.Sethi@xxxxxxx>;
> Pankaj Gupta <pankaj.gupta@xxxxxxx>; Gaurav Jain <gaurav.jain@xxxxxxx>;
> herbert@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux-
> crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx>; Dan Douglass
> <dan.douglass@xxxxxxx>; Vipul Kumar <vipul_kumar@xxxxxxxxxx>
> Subject: [PATCH] crypto: caam - adjust RNG timing to support more devices
>
> From: Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx>
>
> Adjust RNG timing parameters to support more i.MX6 devices.
>
> Signed-off-by: Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx>
> Signed-off-by: Dan Douglass <dan.douglass@xxxxxxx>
> Signed-off-by: Vipul Kumar <vipul_kumar@xxxxxxxxxx>
> Signed-off-by: Horia Geantă <horia.geanta@xxxxxxx>
> ---
> drivers/crypto/caam/ctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index
> 5fed3cf354c0..62dd069942e4 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -383,8 +383,8 @@ static void kick_trng(struct device *dev, int ent_delay)
> wr_reg32(&r4tst->rtsdctl, val);
> /* min. freq. count, equal to 1/4 of the entropy sample length */
> wr_reg32(&r4tst->rtfrqmin, ent_delay >> 2);
> - /* disable maximum frequency count */
> - wr_reg32(&r4tst->rtfrqmax, RTFRQMAX_DISABLE);
> + /* max. freq. count, equal to 16 times the entropy sample length */
> + wr_reg32(&r4tst->rtfrqmax, ent_delay << 4);
> /* read the control register */
> val = rd_reg32(&r4tst->rtmctl);
> start_rng:
> --
> 2.25.1