Re: [PATCH 0/3] pinctrl: check memory returned by devm_kasprintf()

From: Andy Shevchenko
Date: Thu Jun 15 2023 - 07:06:04 EST


On Thu, Jun 15, 2023 at 01:53:30PM +0300, Claudiu Beznea wrote:
> Hi,
>
> While browsing some code I noticed that there are places where pointer
> returned by devm_kasprintf() or kasprintf() is not checked. Thus I've
> tooked the chance and fixed this (by updating kmerr.cocci script,
> changes published at [1]).

Thank you for fixing this!
Individual patches are commented by me.

> [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@xxxxxxxxxxxxx/
>
> Claudiu Beznea (3):
> pinctrl: mcp23s08: check return value of {devm_}kasprintf()
> pinctrl: microchip-sgpio: check return value of devm_kasprintf()
> pinctrl: at91-pio4: check return value of devm_kasprintf()
>
> drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++
> drivers/pinctrl/pinctrl-mcp23s08_spi.c | 3 +++
> drivers/pinctrl/pinctrl-microchip-sgpio.c | 3 +++
> 3 files changed, 8 insertions(+)
>
> --
> 2.34.1
>

--
With Best Regards,
Andy Shevchenko