Re: [PATCH] NFSv4.2: fix wrong shrinker_id

[Qi Zheng]

On 2023/6/15 10:46, Qi Zheng wrote:
> On 2023/6/15 02:06, kernel test robot wrote:
> > Hi Qi,
> >
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on linus/master]
> > [also build test ERROR on trondmy-nfs/linux-next v6.4-rc6 next-20230614]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url:    
> > https://github.com/intel-lab-lkp/linux/commits/Qi-Zheng/NFSv4-2-fix-wrong-shrinker_id/20230614-152853
> > base:   linus/master
> > patch link:    
> > https://lore.kernel.org/r/20230614072443.3264264-1-qi.zheng%40linux.dev
> > patch subject: [PATCH] NFSv4.2: fix wrong shrinker_id
> > config: i386-debian-10.3 
> > (https://download.01.org/0day-ci/archive/20230615/202306150121.cN9iKnvx-lkp@xxxxxxxxx/config)
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce (this is a W=1 build):
> >          git checkout linus/master
> >          b4 shazam 
> > https://lore.kernel.org/r/20230614072443.3264264-1-qi.zheng@xxxxxxxxx
> >          # save the config file
> >          mkdir build_dir && cp config build_dir/.config
> >          make W=1 O=build_dir ARCH=i386 olddefconfig
> >          make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new 
> > version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: 
> > https://lore.kernel.org/oe-kbuild-all/202306150121.cN9iKnvx-lkp@xxxxxxxxx/
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > > > ERROR: modpost: "free_prealloced_shrinker" [fs/nfs/nfsv4.ko] undefined!
> > > > ERROR: modpost: "register_shrinker_prepared" [fs/nfs/nfsv4.ko] 
> > > > undefined!
> > > > ERROR: modpost: "prealloc_shrinker" [fs/nfs/nfsv4.ko] undefined!
>
> Ah, these three functions need to be exported. Will fix it in the v2.

Or we can just swap the order of register_shrinker() and 
list_lru_init_memcg().

> >