Re: [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver

[Tao Zhang]

On 6/12/2023 11:35 PM, Suzuki K Poulose wrote:
> On 12/06/2023 08:07, Tao Zhang wrote:
> > Introduce the new subtype of "CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM"
> > for TPDM components in driver.
> >
> > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/coresight-core.c | 1 +
> >   drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
> >   include/linux/coresight.h                    | 1 +
> >   3 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-core.c 
> > b/drivers/hwtracing/coresight/coresight-core.c
> > index 118fcf2..23b18c2 100644
> > --- a/drivers/hwtracing/coresight/coresight-core.c
> > +++ b/drivers/hwtracing/coresight/coresight-core.c
> > @@ -1093,6 +1093,7 @@ static int coresight_validate_source(struct 
> > coresight_device *csdev,
> >         if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&
> >           subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
> > +        subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM &&
>
> minor nit: Alignment. Please always double check your patch for
> styling issues.
>
>
> Otherwise looks good to me

Sure, I will check all the patches and update to the next patch series soon.

Do you have more review comments on other patches?


Best,

Tao

> Suzuki