Re: [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support

[H. Nikolaus Schaller]

Hi Pual,


> Am 15.06.2023 um 10:45 schrieb H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>:
> 
> Hi Paul,
> 
>> Am 15.06.2023 um 10:39 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:
>> 
>> Hi Nikolaus,
>> 
>> Le 15 juin 2023 09:00, "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx> a écrit :
>>> 
>>> Hi Paul, 
>>> I was in holidays and could not review this series earlier. 
>>> 
>>> 
>>>> Am 04.06.2023 um 16:56 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>: 
>>>> 
>>>> Hi, 
>>>> 
>>>> Here's a set of patches to add support for the WiFi / Bluetooth chip on 
>>>> the CI20. 
>>>> 
>>>> WiFi works pretty well, provided it is used with the latest firmware 
>>>> provided by linux-firmware. Bluetooth does not work very well here, as 
>>>> I cannot get my wireless keyboard to pair; but it does detect it, and it 
>>>> does see they key presses when I type the pairing code. 
>>>> 
>>>> I only tested with a somewhat recent (~2022) Buildroot-based userspace. 
>>>> I enabled WEXT compatibility because the CI20 is typically used with a 
>>>> very old userspace, but I did not try to use it with old tools like 
>>>> ifconfig/iwconfig. 
>>> 
>>> ^^^ great since not everyone is using memory hungry latest user-space and 
>>> ifconfig/iwconfig is also available on some other OS so users like me 
>>> can share scripts. 
>>> 
>>> 
>>> But I had quite some issues with this series. 
>>> 
>>> 1. I could not boot my CI20 V2a board after applying the full series to v6.4-rc6 
>>> 2. bisecting failed because vcc_33v is used in a patch preceding its definition 
>>>   leading to DTC compile abort 
>>> 3. after fixing I could bisect that "MIPS: DTS: CI20: Fix ACT8600 regulator node names" 
>>>   is the first bad commit - although I don't see immediately why 
>>> 
>>> So this series seems to be severely broken and I could not even come to 
>>> a test of WiFi and/or Bluetooth which the series claims to support. 
>> 
>> Well, that's strange. I can assure you it boots and works here.
>> 
>> Maybe it is a board difference; I have a non-square green board - so the earlier version.
> 
> Ok, my V2a is the bordeaux one. That may indeed make a difference.
> 
>> 
>> Since this patch will actually make the various ACT8600 regulators work at their specified voltage, maybe the voltage on one of the updated regulators is wrong?
>> 
>> Maybe change the regulators one by one back to their old name, until you find the one that is problematic? That may give us more info.
> 
> That is what I also have though about but have not yet done.
> Will try as soon as I find a time slot.

I have reverted the whole patch (had only a conflict in wifi_io / LDO6) and now I can boot.

But do not see a WiFi or Bluetooth interface.

So it looks as if the CI20 variants are indeed different. Which would also explain why we
originally came up with two different solutions to add WiFi.

Next I will try to bisect the individual changes...

> 
>> 
>>> Comments to some individual patches follow. 
>> 
>> Sorry about the vcc_33v. Honest mistake.
>> 
>> Thomas: are you able to drop this series from mips-next, or should I/we send fixup patches instead?
> 
> Well, mistakes happen.
> 
> Best regards,
> Nikolaus
> 
>> 
>> Cheers,
>> -Paul
>> 
>>> Best regards and looking forward to a v2 for testing, 
>>> Nikolaus 
>>> 
>>> 
>>>> 
>>>> Cheers, 
>>>> -Paul 
>>>> 
>>>> Paul Cercueil (9): 
>>>>  MIPS: DTS: CI20: Fix regulators 
>>>>  MIPS: DTS: CI20: Fix ACT8600 regulator node names 
>>>>  MIPS: DTS: CI20: Add parent supplies to ACT8600 regulators 
>>> 
>>> ^^^ should IMHO be a separate series since it is not directly related to WiFi / Bluetooth 
>>> 
>>>>  MIPS: DTS: CI20: Do not force-enable CIM and WiFi regulators 
>>>>  MIPS: DTS: CI20: Misc. cleanups 
>>> 
>>> ^^^ these two do not compile 
>>> The Misc. cleanups do not belong to this topic. 
>>> 
>>>>  MIPS: DTS: CI20: Parent MSCMUX clock to MPLL 
>>> 
>>> ^^^ this is only loosely related to Wifi / Bluetooth 
>>> 
>>>>  MIPS: DTS: CI20: Enable support for WiFi / Bluetooth 
>>>>  MIPS: configs: CI20: Regenerate defconfig 
>>>>  MIPS: configs: CI20: Enable WiFi / Bluetooth 
>>>> 
>>>> arch/mips/boot/dts/ingenic/ci20.dts | 148 +++++++++++++++++++--------- 
>>>> arch/mips/configs/ci20_defconfig    |  47 ++++++--- 
>>>> 2 files changed, 133 insertions(+), 62 deletions(-) 
>>>> 
>>>> -- 
>>>> 2.39.2 
>>>> 
>>> 
>