Re: [PATCH v2 3/4] gpio: aggregator: Set up a parser of delay line parameters

From: Andy Shevchenko
Date: Thu Jun 15 2023 - 04:53:15 EST


On Thu, Jun 15, 2023 at 9:37 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Thu, Jun 15, 2023 at 1:14 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > The aggregator mode can also handle properties of the platform,
> > that do not belong to the GPIO controller itself. One of such
> > a property is a signal delay line. Set up a parser to support it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> I guess this is one of those instances where we actually need some OF-specific
> code for parsing the special case, and other HW descriptions will need
> other special code. It's fine for non-trivial stuff I think.

Actually if you look into IIO, the xlate there is fwnode specific
nowadays and theoretically the specifics of OF can be parsed in ACPI
as well. I would like to get rid of OF_GPIO completely, but let's
see...

> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko