Re: [PATCH] drm/amdkfd: Switch over to memdup_user()

From: kernel test robot
Date: Thu Jun 15 2023 - 02:33:24 EST


Hi Jiapeng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20230613]
[cannot apply to drm-misc/drm-misc-next v6.4-rc6 v6.4-rc5 v6.4-rc4 linus/master v6.4-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Jiapeng-Chong/drm-amdkfd-Switch-over-to-memdup_user/20230614-100553
base: next-20230613
patch link: https://lore.kernel.org/r/20230614020432.44044-1-jiapeng.chong%40linux.alibaba.com
patch subject: [PATCH] drm/amdkfd: Switch over to memdup_user()
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230615/202306151407.U4D2AMDM-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
git checkout next-20230613
b4 shazam https://lore.kernel.org/r/20230614020432.44044-1-jiapeng.chong@xxxxxxxxxxxxxxxxx
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306151407.U4D2AMDM-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c: In function 'get_queue_ids':
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:2815:24: warning: returning 'long int' from a function with return type 'uint32_t *' {aka 'unsigned int *'} makes pointer from integer without a cast [-Wint-conversion]
2815 | return PTR_ERR(queue_ids);
| ^~~~~~~~~~~~~~~~~~


vim +2815 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c

2804
2805 static uint32_t *get_queue_ids(uint32_t num_queues, uint32_t *usr_queue_id_array)
2806 {
2807 size_t array_size = num_queues * sizeof(uint32_t);
2808 uint32_t *queue_ids = NULL;
2809
2810 if (!usr_queue_id_array)
2811 return NULL;
2812
2813 queue_ids = memdup_user(usr_queue_id_array, array_size);
2814 if (IS_ERR(queue_ids))
> 2815 return PTR_ERR(queue_ids);
2816
2817 return queue_ids;
2818 }
2819

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki