RE: [net PATCH v2] net: ethernet: stmicro: stmmac: fix possible memory leak in __stmmac_open

[Jose Abreu]

From: Christian Marangi <ansuelsmth@xxxxxxxxx>
Date: Wed, Jun 14, 2023 at 10:17:14

> Fix a possible memory leak in __stmmac_open when stmmac_init_phy fails.
> It's also needed to free everything allocated by stmmac_setup_dma_desc
> and not just the dma_conf struct.
> 
> Drop free_dma_desc_resources from __stmmac_open and correctly call
> free_dma_desc_resources on each user of __stmmac_open on error.
> 
> Reported-by: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>
> Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Thanks for the fix.

Reviewed-by: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>

Thanks,
Jose