Re: [PATCH v7 08/22] net/tcp: Add AO sign to RST packets
From: kernel test robot
Date: Wed Jun 14 2023 - 21:26:15 EST
Hi Dmitry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on b6dad5178ceaf23f369c3711062ce1f2afc33644]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230615-071334
base: b6dad5178ceaf23f369c3711062ce1f2afc33644
patch link: https://lore.kernel.org/r/20230614230947.3954084-9-dima%40arista.com
patch subject: [PATCH v7 08/22] net/tcp: Add AO sign to RST packets
config: i386-randconfig-r021-20230612 (https://download.01.org/0day-ci/archive/20230615/202306150911.gIaFpxg9-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
git checkout b6dad5178ceaf23f369c3711062ce1f2afc33644
b4 shazam https://lore.kernel.org/r/20230614230947.3954084-9-dima@xxxxxxxxxx
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/ipv6/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306150911.gIaFpxg9-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_send_reset':
>> net/ipv6/tcp_ipv6.c:1136:1: warning: label 'out' defined but not used [-Wunused-label]
1136 | out:
| ^~~
vim +/out +1136 net/ipv6/tcp_ipv6.c
2045a93527d963 Dmitry Safonov 2023-06-15 1110
c24b14c46bb88d Song Liu 2017-10-23 1111 if (sk) {
c24b14c46bb88d Song Liu 2017-10-23 1112 oif = sk->sk_bound_dev_if;
052e0690f1f62f Eric Dumazet 2019-07-10 1113 if (sk_fullsock(sk)) {
052e0690f1f62f Eric Dumazet 2019-07-10 1114 const struct ipv6_pinfo *np = tcp_inet6_sk(sk);
052e0690f1f62f Eric Dumazet 2019-07-10 1115
c24b14c46bb88d Song Liu 2017-10-23 1116 trace_tcp_send_reset(sk, skb);
052e0690f1f62f Eric Dumazet 2019-07-10 1117 if (np->repflow)
052e0690f1f62f Eric Dumazet 2019-07-10 1118 label = ip6_flowlabel(ipv6h);
e9a5dceee56cb5 Eric Dumazet 2019-09-24 1119 priority = sk->sk_priority;
dc6456e938e938 Antoine Tenart 2023-04-27 1120 txhash = sk->sk_txhash;
052e0690f1f62f Eric Dumazet 2019-07-10 1121 }
f6c0f5d209fa80 Eric Dumazet 2019-09-24 1122 if (sk->sk_state == TCP_TIME_WAIT) {
50a8accf10627b Eric Dumazet 2019-06-05 1123 label = cpu_to_be32(inet_twsk(sk)->tw_flowlabel);
f6c0f5d209fa80 Eric Dumazet 2019-09-24 1124 priority = inet_twsk(sk)->tw_priority;
9258b8b1be2e1e Eric Dumazet 2022-09-22 1125 txhash = inet_twsk(sk)->tw_txhash;
f6c0f5d209fa80 Eric Dumazet 2019-09-24 1126 }
323a53c41292a0 Eric Dumazet 2019-06-05 1127 } else {
a346abe051bd2b Eric Dumazet 2019-07-01 1128 if (net->ipv6.sysctl.flowlabel_reflect & FLOWLABEL_REFLECT_TCP_RESET)
323a53c41292a0 Eric Dumazet 2019-06-05 1129 label = ip6_flowlabel(ipv6h);
c24b14c46bb88d Song Liu 2017-10-23 1130 }
c24b14c46bb88d Song Liu 2017-10-23 1131
e92dd77e6fe0a3 Wei Wang 2020-09-08 1132 tcp_v6_send_response(sk, skb, seq, ack_seq, 0, 0, 0, oif, key, 1,
2045a93527d963 Dmitry Safonov 2023-06-15 1133 ipv6_get_dsfield(ipv6h), label, priority, txhash,
2045a93527d963 Dmitry Safonov 2023-06-15 1134 ao_key, traffic_key, rcv_next, ao_sne);
658ddaaf6694ad Shawn Lu 2012-01-31 1135
3b24d854cb3538 Eric Dumazet 2016-04-01 @1136 out:
658ddaaf6694ad Shawn Lu 2012-01-31 1137 rcu_read_unlock();
ecc51b6d5ca04b Arnaldo Carvalho de Melo 2005-12-12 1138 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1139
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki