Re: [PATCH] zram: further limit recompression threshold

[Andrew Morton]

On Wed, 14 Jun 2023 23:13:12 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:

> Recompression threshold should be below huge-size-class
> watermark.

The changelog explains what the code does, but not why it does it?

> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev,
>  		}
>  	}
>  
> -	if (threshold >= PAGE_SIZE)
> +	if (threshold >= huge_class_size)
>  		return -EINVAL;
>  
>  	down_read(&zram->init_lock);
> -- 
> 2.41.0.162.gfafddb0af9-goog