Re: [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy

From: Kees Cook
Date: Wed Jun 14 2023 - 14:36:11 EST


On Tue, 30 May 2023 16:22:02 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]

Build tested defconfig with GCC 13.1 from:
https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/

Applied to for-next/hardening, thanks!

[1/1] of/flattree: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/a7969f58df35

--
Kees Cook