Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings

[Krzysztof Kozlowski]

On 14/06/2023 18:48, Konrad Dybcio wrote:
> On 14.06.2023 18:47, Krzysztof Kozlowski wrote:
>> On 14/06/2023 18:43, Konrad Dybcio wrote:
>>> On 14.06.2023 18:43, Krzysztof Kozlowski wrote:
>>>> On 14/06/2023 12:22, Konrad Dybcio wrote:
>>>>> The SMD RPM interconnect driver requires different icc tags to the
>>>>> RPMh driver. Add bindings to reflect that.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>>>> ---
>>>>>  include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++
>>>>>  1 file changed, 13 insertions(+)
>>>>>
>>>>> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>>>>> new file mode 100644
>>>>> index 000000000000..2cd56f91e5c5
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>>>>> @@ -0,0 +1,13 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>> +/*
>>>>> + * Copyright (c) 2023, Linaro Limited
>>>>> + */
>>>>> +
>>>>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>>>>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>>>>> +
>>>>> +#define RPM_ACTIVE_TAG		(1 << 0)
>>>>> +#define RPM_SLEEP_TAG		(1 << 1)
>>>>> +#define RPM_ALWAYS_TAG		(RPM_ACTIVE_TAG | RPM_SLEEP_TAG)
>>>>
>>>> Where are these used? I don't see any DTS in your patchset. Did you send
>>>> it separately?
>>> In the driver for now, e.g. patch 19. DTS can only come after the
>>> driver is fixed or things will explode!
>>
>> You reference it in patch 19, but I still do not see the constants being
>> used.
> 
> Fragment of P19:
> 
>  	if (!tag)
> -		tag = QCOM_ICC_TAG_ALWAYS;
> +		tag = RPM_ALWAYS_TAG;

Now I see, thanks:)

Best regards,
Krzysztof