Re: [PATCH] lib/test_printf.c: space required after that ','

From: Andy Shevchenko
Date: Wed Jun 14 2023 - 11:17:10 EST


On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote:
> On Wed, 14 Jun 2023 15:32:30 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@xxxxxxxxxx wrote:
> > > Add missing spaces to clear checkpatch errors:
> > >
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> >
> > Doesn't make any difference to the code, so let do this (unneeded) churn
> > to calm checkpatch down.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> checkpatch is for patches (new code) and should not be run on existing code.

Why does it have -f option? What do you propose to prevent people from using it?

--
With Best Regards,
Andy Shevchenko