Re: [PATCH] perf parse-events: Remove unneeded semicolon

From: Arnaldo Carvalho de Melo
Date: Wed Jun 14 2023 - 09:56:07 EST


Em Wed, Jun 14, 2023 at 04:13:53PM +0800, baomingtong001@xxxxxxxxxx escreveu:
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Was this detected by some tool? Which one?

- Arnaldo

> Signed-off-by: Mingtong Bao <baomingtong001@xxxxxxxxxx>
> ---
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
> if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {
> assert(perf_pmus__supports_extended_type());
> attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> - };
> + }
>
> if (head_config) {
> if (config_attr(&attr, head_config, parse_state->error,

--

- Arnaldo