Re: [PATCH blktests v1] nvme/040: Free loop back resources

From: Daniel Wagner
Date: Wed Jun 14 2023 - 07:27:16 EST


On Wed, Jun 14, 2023 at 11:13:18AM +0000, Shinichiro Kawasaki wrote:
> On Jun 12, 2023 / 16:29, Daniel Wagner wrote:
> > The tests does not cleanup all resources after it has finished. This
> > leads to rm not being able to remove the TMPDIR cleanly:
> >
> > + rm -rf blktests/results/tmpdir.nvme.040.m2J
> > rm: cannot remove 'blktests/results/tmpdir.nvme.040.m2J': Directory not empty
> >
> > Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
>
> Hi Daniel, thanks for the patch. It looks good to me. Now the test case leaves a
> loop device. This patch avoids it. Good.
>
> Question, I do not observe the rm command failure in my test environments. Do
> you have insight why you were able to find the failure?

I am running the tests inside a VM and I am sharing a part of my host filesystem
via NFS which contain the blktests. If I understood it correctly, the NFS server
is behaving slightly differently here. I can't observe it either with xfs or
btrfs.