Re: [PATCH] b43legacy: Remove unneeded variable

[Johannes Berg]

On Wed, 2023-06-14 at 13:52 +0800, wuyonggang001@xxxxxxxxxx wrote:
> Fix the following coccicheck warning:
> 
> drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded 
> variable: "count".

That may be a warning that it gives.

> Signed-off-by: Yonggang Wu <wuyonggang001@xxxxxxxxxx>
> ---
>   drivers/net/wireless/broadcom/b43legacy/debugfs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c 
> b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
> index 6b0e8d117061..55a067eaa52d 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
> @@ -73,7 +73,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev 
> *dev, char *buf, size_t bufs
>           (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
>           (unsigned int)(tsf & 0xFFFFFFFFULL));
> 
> -    return count;
> +    return 0;
> 

However, that doesn't even fix the warning, and it is actually also
completely wrong.

Please don't submit patches where you don't even understand the code.

johannes