Re: [PATCH 1/2] dt-bindings: arm: idle-states: Add idle-state-disabled property

[Tushar Nimkar]

Thanks Krzysztof for reviewing,

On 6/9/2023 6:44 PM, Krzysztof Kozlowski wrote:
> On 08/06/2023 10:55, Tushar Nimkar wrote:
> > This change adds idle-state-disabled property using which certain or all
>
> Please do not use "This commit/patch", but imperative mood. See longer
> explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
Sure, will update in next version.
> > idle-states can be kept disabled during boot-up. Once boot-up is completed
> > same can be enabled using below command.
>
> I don't understand and you did not explain here, why this is useful and
> why this is needed.
I will update commit text to why this is useful in new version.
> > echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable
>
>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Signed-off-by: Tushar Nimkar <quic_tnimkar@xxxxxxxxxxx>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.
Yes, In new version will take care.
> > ---

> > +          echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable
>
> This is Linux specific command, so does not fit the bindings.
Will remove in new version.
> Best regards,
> Krzysztof

Thanks,
Tushar