Re: [PATCH 1/3] dt-bindings: ROHM BU27010 RGBC + flickering sensor

From: Krzysztof Kozlowski
Date: Wed Jun 14 2023 - 02:37:28 EST


On 14/06/2023 07:32, Matti Vaittinen wrote:
>>> +properties:
>>> + compatible:
>>> + const: rohm,bu27010
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + vdd-supply: true
>>
>> Isn't vdd-supply required for the hardware to work? How does it get the
>> power otherwise?
>
> The BU27010 works by magic smoke. When smoke leaks out the sensor no
> longer works.
>
> Ehh, I think you are right. My thinking was that it is not uncommon for
> people to not have all fixed regulators present in device-tree. But I
> agree, this does not mean we should encourage that. I'll add supply to
> the list of the required properties.
>
If the device actually requires a regulator, it should be required by
the bindings, even if it leads to dummies or fixed regulators on the
board DTS.

Best regards,
Krzysztof