Re: [PATCH v3 04/57] kbuild: Drop -Wdeclaration-after-statement

[Masahiro Yamada]

On Mon, Jun 12, 2023 at 6:39 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> With the advent on scope-based resource management it comes really
> tedious to abide by the contraints of -Wdeclaration-after-statement.

Where is the context of Linus' suggested-by?

I do not know where this came from.
I suddenly got a huge v3 in my mailbox.


I see an equivalent patch submitted last year:
https://lore.kernel.org/lkml/Y1w031iI6Ld29IVT@p183/

Linus rejected it. Did he change his mind?



> It will still be recommeneded to place declarations at the start of a
> scope where possible, but it will no longer be enforced.

If you remove the warning, we will not be able to
detect code that opts out the recommendation
for no good reason.





-- 
Best Regards
Masahiro Yamada