Re: [PATCH] serial: 8250_omap: Use force_suspend and resume for system suspend

[Dhruva Gole]

Hi Tony,

Thanks for the fix!

On 14/06/23 10:29, Tony Lindgren wrote:
> We should not rely on autosuspend timeout for system suspend. Instead,
> let's use force_suspend and force_resume functions. Otherwise the serial
> port controller device may not be idled on suspend.
>
> As we are doing a register write on suspend to configure the serial port,
> we still need to runtime PM resume the port on suspend.
>
> While at it, let's switch to pm_runtime_resume_and_get() and check for
> errors returned. And let's add the missing line break before return to the
> suspend function while at it.
>
> Fixes: 09d8b2bdbc5c ("serial: 8250: omap: Provide ability to enable/disable UART as wakeup source")
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---

Tested-by: Dhruva Gole <d-gole@xxxxxx>

>   drivers/tty/serial/8250/8250_omap.c | 20 +++++++++++++++-----
>   1 file changed, 15 insertions(+), 5 deletions(-)
> [...]


--
Thanks and Regards,
Dhruva Gole