Re: [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init()

From: Chang S. Bae
Date: Wed Jun 14 2023 - 01:03:50 EST


On 6/13/2023 4:39 PM, Thomas Gleixner wrote:
@@ -2396,6 +2393,13 @@ void __init arch_cpu_finalize_init(void)
'0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
}
+ /*
+ * Must be before alternatives because it might set or clear
+ * feature bits.
+ */
+ fpu__init_system();
+ fpu__init_cpu();

fpu__init_cpu() appears to be duplicated here because fpu__init_system() invoked this already:

void __init fpu__init_system(void)
{
...
/*
* The FPU has to be operational for some of the
* later FPU init activities:
*/
fpu__init_cpu();
...
}

https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/arch/x86/kernel/fpu/init.c?h=init#n223

Thanks,
Chang