Re: [PATCH] nvme: Print capabilities changes just once

From: Christoph Hellwig
Date: Wed Jun 14 2023 - 01:01:14 EST


On Tue, Jun 13, 2023 at 04:00:58PM -0600, Keith Busch wrote:
> On Tue, Jun 13, 2023 at 10:55:37AM -0700, Breno Leitao wrote:
> > This current dev_info() could be very verbose and being printed very
> > frequently depending on some userspace application sending some specific
> > commands.
> >
> > Let's turn it into a dev_info_once(), since it is not useful to know
> > about it all the time.
>
> This looks good to me. Vendors sometimes put unnecessary effects in the
> log, and spamming the same recommendation to repeated operations isn't
> going to be helpful. I expect anyone who knows what they're doing can
> consult the effects log directly and take appropriate action on their
> own.

Hmm, once seems very little. It might make more sense to do this
once and then skip it until the controller has been reset.