Re: [PATCH v2] usb: typec: ucsi: Mark dGPUs as DEVICE scope

From: Andi Shyti
Date: Tue Jun 13 2023 - 20:16:52 EST


Hi Mario,

On Thu, May 18, 2023 at 11:11:50AM -0500, Mario Limonciello wrote:
> power_supply_is_system_supplied() checks whether any power
> supplies are present that aren't batteries to decide whether
> the system is running on DC or AC. Downstream drivers use
> this to make performance decisions.
>
> Navi dGPUs include an UCSI function that has been exported
> since commit 17631e8ca2d3 ("i2c: designware: Add driver
> support for AMD NAVI GPU").
>
> This UCSI function registers a power supply since commit
> 992a60ed0d5e ("usb: typec: ucsi: register with power_supply class")
> but this is not a system power supply.
>
> As the power supply for a dGPU is only for powering devices connected
> to dGPU, create a device property to indicate that the UCSI endpoint
> is only for the scope of `POWER_SUPPLY_SCOPE_DEVICE`.
>
> Link: https://lore.kernel.org/lkml/20230516182541.5836-2-mario.limonciello@xxxxxxx/
> Reviewed-by: Evan Quan <evan.quan@xxxxxxx>
> Tested-by: Evan Quan <evan.quan@xxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Thanks,
Andi