Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Conor Dooley]

On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> The "linux,keycode" property is non-standard. Add the common property
> "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> is not propagated.

This is actually used in the driver for this device, should the driver
not also be updated to use the corrected property?


> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> index 6052129bf852..e879bc0be8e2 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> @@ -105,6 +105,11 @@ properties:
>        linux,keycode:
>          $ref: /schemas/types.yaml#/definitions/uint32
>          default: 116
> +        deprecated: true
> +
> +      linux,keycodes:
> +        maxItems: 1
> +        default: 116
>  
>      required:
>        - compatible
> -- 
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature