Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static
From: Kees Cook
Date: Tue Jun 13 2023 - 16:31:11 EST
On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote:
> smatch reports
> fs/proc/proc_sysctl.c:32:18: warning: symbol
> 'sysctl_mount_point' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
--
Kees Cook