Re: [PATCH v2 7/8] dt-bindings: rtc: isl12022: add #clock-cells property

From: Krzysztof Kozlowski
Date: Tue Jun 13 2023 - 15:11:01 EST


On 13/06/2023 15:00, Rasmus Villemoes wrote:
> The isl12022 has a dual-purpose irq/f_out pin, which can either be
> used as an interrupt or clock output.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/rtc/intersil,isl12022.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml
> index d5d3a687a34d..a9ef68b5fdcd 100644
> --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml
> +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml
> @@ -11,6 +11,13 @@ maintainers:
>
> allOf:
> - $ref: rtc.yaml#
> + # If #clock-cells is present, interrupts must not be present
> + - if:
> + required:
> + - '#clock-cells'
> + then:
> + properties:
> + interrupts: false

Entire allOf block should be like in example-schema, so before
unevaluatedProperties. Please put it in correct place in your first
patch so here it does not have to be moved.

Best regards,
Krzysztof