Re: [PATCH net v2 2/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7530

[Arınç ÜNAL]

On 13.06.2023 20:39, Vladimir Oltean wrote:
> On Tue, Jun 13, 2023 at 08:30:28PM +0300, Arınç ÜNAL wrote:
> > That fixes port 5 on certain variants of the MT7530 switch, as it was
> > already working on the other variants, which, in conclusion, fixes port 5 on
> > all MT7530 variants.
>
> Ok. I didn't pay enough attention to the commit message.
>
> > And no, trapping works. Having only CPU port 5 defined on the devicetree
> > will cause the CPU_PORT bits to be set to port 5. There's only a problem
> > when multiple CPU ports are defined.
>
> Got it. Then this is really not a problem, and the commit message frames
> it incorrectly.

Actually this patch fixes the issue it describes. At the state of this 
patch, when multiple CPU ports are defined, port 5 is the active CPU 
port, CPU_PORT bits are set to port 6.

Once "the patch that prefers port 6, I could easily find the exact name 
but your mail snipping makes it hard" is applied, this issue becomes 
redundant.

> > > So how about settling on that as a more modest Fixes: tag, and
> > > explaining clearly in the commit message what's affected?
> >
> > I don't see anything to change in the patch log except addressing Russell's
> > comments.
>
> Ok. I see Russell has commented on v4, though I don't see that he particularly
> pointed out that this fixes a problem which isn't yet a problem. I got lost in
> all the versions. v2 and v3 are out of my inbox now :)

All good, I had to quickly roll v3 as v2 had wrong author information 
and I couldn't risk getting v2 applied.

Arınç