Re: [PATCH v9 03/42] mm: Make pte_mkwrite() take a VMA

From: Edgecombe, Rick P
Date: Tue Jun 13 2023 - 12:20:49 EST


On Tue, 2023-06-13 at 10:42 +0300, Mike Rapoport wrote:
> > In a previous patches, pte_mkwrite() was renamed
> > pte_mkwrite_novma() and
> > callers that don't have a VMA were changed to use
> > pte_mkwrite_novma(). So
>
> Maybe
> This is the third step so pte_mkwrite() was renamed to
> pte_mkwrite_novma()
> and ...

Hmm, yea.

>
> > now change pte_mkwrite() to take a VMA and change the remaining
> > callers to
> > pass a VMA. Apply the same changes for pmd_mkwrite().
> >
> > No functional change.
> >
> > Suggested-by: David Hildenbrand <david@xxxxxxxxxx>
> > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
>
> Reviewed-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>

Thanks!