Re: [PATCH] net/mediatek: strlcpy withreturn

[Azeem Shaikh]

On Tue, Jun 13, 2023 at 4:35 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
>
> Azeem Shaikh <azeemshaikh38@xxxxxxxxx> wrote:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since DEV_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx>
>
> The title should be:
>
> wifi: mt7601u: replace strlcpy() with strscpy()
>
> I can fix that, no need to resend because of this.
>

Thanks Kalle!

> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@xxxxxxxxx/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>