Re: [PATCH v8 4/5] erofs: unify inline/shared xattr iterators for listxattr/getxattr

[Gao Xiang]

On 2023/6/13 15:41, Jingbo Xu wrote:

...

> +
> +int erofs_getxattr(struct inode *inode, int index,
> +		   const char *name,
> +		   void *buffer, size_t buffer_size)

I changed these line above into:

int erofs_getxattr(struct inode *inode, int index, const char *name,
		   void *buffer, size_t buffer_size)

> +{
> +	int ret;


...

>   ssize_t erofs_listxattr(struct dentry *dentry,
> @@ -568,8 +523,9 @@ ssize_t erofs_listxattr(struct dentry *dentry,

I also move erofs_listxattr definition into a line (since it's just
80 chars).


Otherwise it looks good to me,
Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Thanks,
Gao Xiang