Re: [PATCH v3 01/23] dt-bindings: interconnect: Add Qcom RPM ICC bindings

[Konrad Dybcio]

On 13.06.2023 13:11, Stephan Gerhold wrote:
> On Mon, Jun 12, 2023 at 08:24:18PM +0200, Konrad Dybcio wrote:
>> The SMD RPM interconnect driver requires different icc tags to the
>> RPMh driver. Add bindings to reflect that.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>> ---
>>  include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>> new file mode 100644
>> index 000000000000..ef61006c9c58
>> --- /dev/null
>> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>> @@ -0,0 +1,13 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) 2023, Linaro Limited
>> + */
>> +
>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>> +
>> +#define RPM_ACTIVE_TAG		BIT(0)
>> +#define RPM_SLEEP_TAG		BIT(1)
> 
> BIT(n) doesn't work in dt-bindings (syntax error), can you change this
> to (1 << 0) / (1 << 1)?
Just including the binding did not show it.. You're right..

Konrad
> 
> Thanks!
>