Re: [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support

From: Jacky Huang
Date: Tue Jun 13 2023 - 07:03:26 EST


Dear Greg,


On 2023/6/13 下午 06:29, Greg KH wrote:
On Mon, Jun 12, 2023 at 02:53:55AM +0000, Jacky Huang wrote:
From: Jacky Huang <ychuang3@xxxxxxxxxxx>

This adds UART and console driver for Nuvoton ma35d1 Soc.
It supports full-duplex communication, FIFO control, and
hardware flow control.
You don't specify here what your tty device name is going to be, why?

It's not written anywhere, is that intentional?

Same for your tty major/minor, what numbers are you using that might
also be in use by a different device in the system?

thanks,

greg k-h

I will add description about the tty name to the log.
In practical testing, we specified in the u-boot parameters
to use ttyNVT0 for the console, and it worked fine.

Best regards,
Jacky Huang