Re: [PATCH v3 1/8] dt-bindings: connector: usb-connector: add a gpio used to determine the Type-C port plug orientation

[neil . armstrong]

On 13/06/2023 11:02, Krzysztof Kozlowski wrote:
> On 13/06/2023 10:54, Neil Armstrong wrote:
> > On 13/06/2023 10:13, Krzysztof Kozlowski wrote:
> > > On 13/06/2023 09:55, Neil Armstrong wrote:
> > > > On some platforms, the Type-C plug orientation is given on a GPIO line.
> > > >
> > > > Document this optional Type-C connector property, and take the
> > > > assumption an active level represents an inverted/flipped orientation.
> > > >
> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > >
> > > Rob had here objections as these are bindings for the connector, not
> > > PMIC glink/altmode. I still doubt that Qualcomm USB Type-C connectors
> > > have such pin exposed. If you open the schematics, the GPIO is actually
> > > coming out from PMIC and is nowhere around the connector. Please drop my
> > > Ack.
> > >
> > > This however could be a pin of the PMIC because it clearly is on the
> > > schematics.
> >
> > Yes it comes from the PMIC, but this part of the PMIC is handled by
> > the PMIC_GLINK firmware service, so the logical place would be into
> > the pmic_glink node with a gpio array in order to handle multi-ports.
>
> I think all PMICs have only one CC_OUT pin, so this would be now
> maxItems: 1, but there will be no problem in growing this later.

Yep, I'll only allow for sm8550-pmic-glink and set maxItems: 1 for now
since it's the first occurence.

Neil

> Best regards,
> Krzysztof