[PATCH v1 1/1] signal: Use %*ph for printing hexdump of a small buffer

From: Andy Shevchenko
Date: Mon Jun 12 2023 - 18:03:36 EST


The kernel already has a helper to print a hexdump of a small
buffer via pointer extension. Use that instead of open coded
variant.

In long term it helps to kill pr_cont() or at least narrow down
its use.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
kernel/signal.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index b5370fe5c198..6be2df76f0b4 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1259,18 +1259,17 @@ static void print_fatal_signal(int signr)
pr_info("potentially unexpected fatal signal %d.\n", signr);

#if defined(__i386__) && !defined(__arch_um__)
- pr_info("code at %08lx: ", regs->ip);
{
+ unsigned char insn[16];
int i;
+
for (i = 0; i < 16; i++) {
- unsigned char insn;
-
- if (get_user(insn, (unsigned char *)(regs->ip + i)))
+ if (get_user(insn[i], (unsigned char __user *)(regs->ip + i)))
break;
- pr_cont("%02x ", insn);
}
+
+ pr_info("code at %08lx: %*ph\n", regs->ip, i, insn);
}
- pr_cont("\n");
#endif
preempt_disable();
show_regs(regs);
--
2.40.0.1.gaa8946217a0b