Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check

From: Yang Shi
Date: Mon Jun 12 2023 - 17:58:15 EST


On Fri, Jun 9, 2023 at 8:41 PM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

Reviewed-by: Yang Shi <shy828301@xxxxxxxxx>

> ---
> mm/memory-tiers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>
> lockdep_assert_held_once(&memory_tier_lock);
>
> - if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> + if (!node_demotion)
> return;
>
> disable_all_demotion_targets();
> --
> 2.27.0
>
>