Re: [PATCH] usb: dwc3-meson-g12a: Fix an error handling path in dwc3_meson_g12a_probe()

From: Martin Blumenstingl
Date: Mon Jun 12 2023 - 16:25:22 EST


On Sat, Jun 10, 2023 at 3:32 PM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> If dwc3_meson_g12a_otg_init() fails, resources allocated by the previous
> of_platform_populate() call should be released, as already done in the
> error handling path.
>
> Fixes: 1e355f21d3fb ("usb: dwc3: Add Amlogic A1 DWC3 glue")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

We should move to devm_of_platform_populate() mid term.
That said, this fix is good for now because it's simple and can be backported.