Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

[Conor Dooley]

On Mon, Jun 12, 2023 at 09:47:12AM +0200, Thomas Zimmermann wrote:
> Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas:

> > But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings
> > from the DRM driver and only match against the new "solomon,ssd130?-i2c"
> > compatible strings. And add a different DT binding schema for the ssd130x
> > driver, if that would mean being able to fix things like the one mentioned
> > in this patch.

If there are different compatibles, then it can always be sorted out
later iff it turns out to be a problem, since new devicetrees should not
be using the deprecated compatibles anyway. I didn't realise that those
deprecated compatibles existed, thanks for your patience.

> > In my opinion, trying to always make the drivers backward compatible with
> > old DTBs only makes the drivers code more complicated for unclear benefit.
> > 
> > Usually this just ends being code that is neither used nor tested. Because
> > in practice most people update the DTBs and kernels, instead of trying to
> > make the DTB a stable ABI like firmware.
> > 
> 
> From my understanding, fixing the resolution is the correct thing to do
> here. Userspace needs to be able to handle these differences.

Fixing meaning correcting, or fixing meaning using a fixed resolution?
Not clear to me what you mean, sorry.

Attachment: signature.asc
Description: PGP signature