Re: [PATCH v4 3/3] riscv: dts: allwinner: d1: Add thermal sensor and thermal zone

From: Conor Dooley
Date: Mon Jun 12 2023 - 13:27:47 EST


On Mon, Jun 12, 2023 at 11:17:20AM +0300, Maxim Kiselev wrote:
> Hi, Conor
>
> пн, 12 июн. 2023 г. в 10:55, Conor Dooley <conor.dooley@xxxxxxxxxxxxx>:
>
> ...
>
> > The RISC-V patchwork automation is complaining about this patch while
> > running dtbs_check:
> > arch/riscv/boot/dts/allwinner/sun20i-d1s-mangopi-mq.dtb: thermal-zones: cpu-thermal: 'trips' is a required property
> > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>
> I didn't add 'trips' because I'm not sure if they should be the same
> for the D1 and the T113s.

I'm sorry, but I am of no help there. Perhaps some of the Allwinner devs
can help you on that front.

> Maybe it's better to drop 'thermal-zones' from this patch and add them
> later in separate patches
> for T113s and D1?

Does it pass dtbs_check with the thermal-zones removed?

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature