Re: [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+)

From: Linus Torvalds
Date: Mon Jun 12 2023 - 12:42:42 EST


On Mon, Jun 12, 2023 at 9:38 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> Quick peek would suggest that it's because io-wq clears PF_IO_WORKER on
> exit, and now we fail the check in coredump_task_exit() that was added.

Oh, that makes sense.

Well, it makes sense for the bug, but that whole

preempt_disable();
current->flags &= ~PF_IO_WORKER;
preempt_enable();

thin in io_worker_exit() does *not* make sense to me.

Does removing those three lines make things "JustWork(tm)"?

Linus