RE: [PATCH v2] cpufreq: amd-pstate: Set default governor to schedutil

[Yuan, Perry]

[AMD Official Use Only - General]

Hi Viresh.

> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Sent: Monday, June 12, 2023 3:26 PM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: rafael.j.wysocki@xxxxxxxxx; Huang, Ray <Ray.Huang@xxxxxxx>;
> Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Sharma, Deepak
> <Deepak.Sharma@xxxxxxx>; Karny, Wyes <Wyes.Karny@xxxxxxx>;
> Shenoy, Gautham Ranjal <gautham.shenoy@xxxxxxx>; Li, Sun peng (Leo)
> <Sunpeng.Li@xxxxxxx>; Huang, Shimmer <Shimmer.Huang@xxxxxxx>;
> Du, Xiaojian <Xiaojian.Du@xxxxxxx>; Meng, Li (Jassmine)
> <Li.Meng@xxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Set default governor to
> schedutil
>
> On 11-06-23, 23:03, Perry Yuan wrote:
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > The Kconfig currently defaults the governor to schedutil on x86_64
> > only when intel-pstate and SMP have been selected.
> >
> > If the kernel is built only with amd-pstate, the default governor
> > should also be schedutil.
> >
> > Cc: Sun Peng (Leo) Li <sunpeng.li@xxxxxxx>
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > Reviewed-by: Leo Li <sunpeng.li@xxxxxxx>
> > Acked-by: Huang Rui <ray.huang@xxxxxxx>
> > Tested-by: Perry Yuan <Perry.Yuan@xxxxxxx>
> > ---
> >  drivers/cpufreq/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > 2c839bd2b051..a1c51abddbc5 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -38,7 +38,7 @@ choice
> >     prompt "Default CPUFreq governor"
> >     default CPU_FREQ_DEFAULT_GOV_USERSPACE if
> ARM_SA1110_CPUFREQ
> >     default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> > -   default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE
> && SMP
> > +   default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if
> (X86_INTEL_PSTATE ||
> > +X86_AMD_PSTATE) && SMP
> >     default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> >     help
> >       This option sets which CPUFreq governor shall be loaded at
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> --
> Viresh

Thank you help to provide the ack flag.
I have added it to the V3.

Perry.