Re: [PATCH v2 1/4] pinctrl: intel: refine set_mux hook

From: Andy Shevchenko
Date: Mon Jun 12 2023 - 11:19:28 EST


On Mon, Jun 12, 2023 at 07:15:59AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:36PM +0530, Raag Jadav wrote:
> > > Utilize a temporary variable for common shift operation inside
> > > ->set_mux() hook and improve readability.
> >
> > Seems the bloat-o-meter statistics is missing here.
>
> I changed the commit message as pointed out by Mika in v1.
> Do I change it back?

No back, only forward!

I.e. you need to update Subject to follow the pattern, ->set_mux()
in this case) and add a note that the change makes code smaller.
It will be two selling points.

--
With Best Regards,
Andy Shevchenko