Re: [Patch v2 1/6] sched/fair: Determine active load balance for SMT sched groups

[Peter Zijlstra]

On Thu, Jun 08, 2023 at 03:32:27PM -0700, Tim Chen wrote:
> @@ -10371,6 +10436,11 @@ static struct sched_group *find_busiest_group(struct lb_env *env)
>  			 */
>  			goto out_balanced;
>  
> +		if (busiest->group_type == group_smt_balance &&
> +		    smt_vs_nonsmt_groups(sds.local, sds.busiest))
> +			/* Let non SMT CPU pull from SMT CPU sharing with sibling */
> +			goto force_balance;
> +
>  		if (busiest->group_weight > 1 &&
>  		    local->idle_cpus <= (busiest->idle_cpus + 1))
>  			/*

Could you please add {} for all of them? The comment makes them all
multi-line.