Re: [PATCH] drivers: target: Fix the conversion to bool in iblock_execute_pr_out

[Chaitanya Kulkarni]

On 6/12/23 01:10, Lu Hongfei wrote:
> The return value of the '==' or '!=' operator are bool, so there's
> no need to convert it to bool again in iblock_execute_pr_out.
>
> Signed-off-by: Lu Hongfei <luhongfei@xxxxxxxx>
> ---
>   drivers/target/target_core_iblock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index 254c33c9788e..ea42cb5d06d4
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -889,7 +889,7 @@ static sense_reason_t iblock_execute_pr_out(struct se_cmd *cmd, u8 sa, u64 key,
>   
>   		ret = ops->pr_preempt(bdev, key, sa_key,
>   				      scsi_pr_type_to_block(type),
> -				      sa == PRO_PREEMPT ? false : true);
> +				      sa != PRO_PREEMPT);
>   		break;
>   	case PRO_RELEASE:
>   		if (!ops->pr_clear) {

this not a fix as current code is not broken ..

-ck