Re: [PATCH 1/2] selftests: mm: remove wrong kernel header inclusion

[David Hildenbrand]

On 12.06.23 11:53, Muhammad Usama Anjum wrote:
> It is wrong to include unprocessed user header files directly. They are
> processed to "<source_tree>/usr/include" by running "make headers" and
> they are included in selftests by kselftest makefiles automatically with
> help of KHDR_INCLUDES variable. These headers should always bulilt
> first before building kselftests.
>
> Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> ---
>   tools/testing/selftests/mm/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 95acb099315e..e6cd60ca9e48 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -29,7 +29,7 @@ MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's/ppc64.*/p
>   # LDLIBS.
>   MAKEFLAGS += --no-builtin-rules
>   
> -CFLAGS = -Wall -I $(top_srcdir) -I $(top_srcdir)/tools/include/uapi $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
> +CFLAGS = -Wall -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
>   LDLIBS = -lrt -lpthread
>   
>   TEST_GEN_PROGS = cow

Still compiles after "make headers", so

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb