Re: [PATCH 3/5] drm/mediatek: Add initialization for mtk_gem_obj

[CK Hu (胡俊光)]

Hi, Jason:

On Fri, 2023-04-07 at 14:46 +0800, Jason-JH.Lin wrote:
> Calling mtk_gem_obj = kzalloc() which returns uninitialized memory,
> because mtk_gem_obj is uninitialized.
> 
> It may cause using uninitialized value mtk_gem_obj->base.resv
> when calling drm_gem_object_init().
> 
> So add initialization for mtk_gem_obj.

So weird, nacked by me.

Regards,
CK

> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC
> MT8173.")
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index a25b28d3ee90..9b8f72ed12e4 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -33,7 +33,7 @@ static const struct drm_gem_object_funcs
> mtk_drm_gem_object_funcs = {
>  static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device
> *dev,
>  						unsigned long size)
>  {
> -	struct mtk_drm_gem_obj *mtk_gem_obj;
> +	struct mtk_drm_gem_obj *mtk_gem_obj = NULL;
>  	int ret;
>  
>  	size = round_up(size, PAGE_SIZE);